FIXED On server restart, id of gumps changes itself

[Krecha]

I think these are changes in the new version of the framework/hash method.

*chief concern right now is gumps changing IDs every restart, breaking player macros

ModernUO implementation:

ModernUO/Projects/Server/Gumps/Gump.cs at 0ffea2e91282dcdeb7378c54c9cbae1d64e8cf1c · modernuo/ModernUO

Ultima Online Server Emulator for the modern era! Contribute to modernuo/ModernUO development by creating an account on GitHub.

github.com

GetHashCode method Returns different values for same string in asp.net core

I have following code written in application. var salt = "0115ee62e6e5e8ea68db9e2d7e72cec85e810ad9566212ffc2c4b76a17ca0b00"; var hashCode = StringComparer.OrdinalIgnoreCase.GetHashCod...

stackoverflow.com

Why is string.GetHashCode() different each time I run my program in .NET Core?

In this post I discuss string.GetHashCode(), why it's randomised, and hash-attacks. I also provide a deterministic implementation you can use when it's safe.

andrewlock.net

 

[Dan]

After doing a little research it seems the best approach is to update the hashing in general. This specific hash, xxhash, is deterministic, made for newer versions of .NET, and it is what MUO uses. The other MUO example is just for backwards compatibility for people who can't/don't want to upgrade.

xxHash - Extremely fast non-cryptographic hash algorithm

There may be some performance issues with the backwards compatibility proposed by MUO if I take the easy way out.

The question now is how easy a total upgrade would be. That one I can't answer yet. Time needed will be the ultimate factor in the immediate short term.

 

[Dan]

GumpHashFix by DocKnight86 · Pull Request #1362 · TrueUO/TrueUO

https://trueuo.com/threads/on-server-restart-id-of-gumps-changes-itself.3723/#post-20839

github.com

If anyone has the know-how to download TrueUO and run their own server I would appreciate some testing of this. I need to make sure gumps still work in general, that macros collect the new hash correctly, and that they can now persist through restarts.

 

[Dan]

I went ahead and pushed this to Heritage.

Please note that only gump IDs obtained after the shard comes online with this patch will persist through the next 7am auto restart.

Please report any issues. I had limited time to test but everything seemed okay.

 

[Dan]

This issue has been fixed.

@Krecha has been awarded 25 Sovereigns.