new sort of lags

[BBB]

Have you guys experienced new lags/freezes after last framework changes or whatever that was about? I havent playing for about two weks and today found out Heritage totally different, some of my old macros and loops not even working at all.

 

[Krecha]

I think something is wrong with the timers - the actions seems to be lazy/lagged.

 

[Dan]

ConcurrentQueueChange by TrueUO · Pull Request #1274 · TrueUO/TrueUO

https://trueuo.com. Contribute to TrueUO/TrueUO development by creating an account on GitHub.

github.com

I did change something in timers to use a ConcurrentQueue over locks. Maybe that introduced some overhead.

I am going to revert it and see if that helps any.

The only thing I can see changed on my end is save times.

 

[Dan]

Alright, I pushed it. Let me know if that helped any or not at all.

 

[BBB]

I would say it helped a lot, but there is still something different Definitely running much smoother now but some of my old macros are still not working, i will try to find out what's wrong. Thanks for your fast engagement Dan, appreciate.

 

[Dan]

So much changed under the hood from .net framework 4.8 to .net 8. The way stuff is internally processed could have changed.

I'll just need feedback to try and tweak things as we go.

Narrowing down certain events will also help.

 

[Krecha]

The lazy/laggy effect is gone now.

 

[Krecha]

Something is still wrong with macros that use buff ico as timers.

 

[Dan]

Could it be an issue with CUO? What spell is that?

 

[Krecha]

This is a bandage healing. I checked on Orion macros with BuffExists and they work, so maybe it is an issue with CUO.

 

[Dan]

They pushed a few updates over the last few weeks as well. If you are in their Discord I'd check out if others are seeing similar issues.

Could also be a mix of issues on both our end and CUOs end. So much was changed. Let's keep gathering information here to see if we can't eventually narrow down a cause.

 

[Krecha]

After more testing - on Orion also the macro does not work properly. Sometimes buffico/BuffExists disappears faster than a bandage heal - and that's is a difference of about one second.

 

[Dan]

Yeah, it is most likely something on our end if the issues only started when we updated the framework.

Is it just healing? Is it just issues with macros that use the existence or non-existence of a buff icon to activate?

 

[Dan]

ModernUOTimersPart1 by TrueUO · Pull Request #1275 · TrueUO/TrueUO

https://trueuo.com. Contribute to TrueUO/TrueUO development by creating an account on GitHub.

github.com

I think I got all the issues with new timers sorted. I am going to push this to Heritage in the next 30 minutes and would appreciate any feedback.

It completely changes how timers work and reduced a lot of overhead. It also uses a timer wheel instead of threading.

The original code was added to TrueUO thanks to the admin of ModernUO. https://github.com/modernuo/ModernUO

 

[BBB]

Not sure what is the cause but it changed nothing with bandage healing timer.
Even without going into details, I immediately noticed that some of my old macros still didn't work.

 

[Krecha]

At 150 dex, healing should take 4s.

double seconds;
seconds = Math.Min(8, Math.Ceiling(11.0 - 150 / 20));
seconds = Math.Max(seconds, 4);

Output: 4

Buffs packet on Heritage - 3s.
Buffs packet on local ServUO - 4s.

 

[Dan]

At 150 dex, healing should take 4s.

double seconds;
seconds = Math.Min(8, Math.Ceiling(11.0 - 150 / 20));
seconds = Math.Max(seconds, 4);

Output: 4

Buffs packet on Heritage - 3s.
Buffs packet on local ServUO - 4s.

GitHub - TrueUO/TrueUO: https://discord.gg/5RtDbkY3fC

https://discord.gg/5RtDbkY3fC. Contribute to TrueUO/TrueUO development by creating an account on GitHub.

github.com

If you get time could you also test it on TrueUO, which is also on the newest .NET 8 and is basically a clone of the Heritage back end.

 

[Krecha]

Buffs packet on local (.NET 8) TrueUO (master) - 3s.

I think - this is a code line that needs to be looked at:

TrueUO/Scripts/Misc/BuffIcons.cs at 7f8363b91711d37875433540f6d6758109b43348 · TrueUO/TrueUO

https://trueuo.com. Contribute to TrueUO/TrueUO development by creating an account on GitHub.

github.com

 

[Dan]

Hmm does ServUO have something different?

History for Scripts/Misc/BuffIcons.cs - TrueUO/TrueUO

https://trueuo.com. Contribute to TrueUO/TrueUO development by creating an account on GitHub.

github.com

The history tab shows that specific file as not being edited in the last 2 years.

I wonder if stuff is now getting processed so fast on the backend that maybe buff icons need an artificial delay, sort of like the action delay in moving items too quickly. Is it just healing or is it all buff icons that are off by 1 second?

 

[Dan]

TrueUO/Scripts/Items/Resource/Bandage.cs at 7f8363b91711d37875433540f6d6758109b43348 · TrueUO/TrueUO

https://trueuo.com. Contribute to TrueUO/TrueUO development by creating an account on GitHub.

github.com

Further down in this method it calls the RemoveBuff.

TrueUO/Scripts/Items/Resource/Bandage.cs at 7f8363b91711d37875433540f6d6758109b43348 · TrueUO/TrueUO

https://trueuo.com. Contribute to TrueUO/TrueUO development by creating an account on GitHub.

github.com